Skip to content

Commit

Permalink
fix: linting
Browse files Browse the repository at this point in the history
  • Loading branch information
rajatbhatta committed Sep 30, 2022
1 parent 22ed999 commit 274346d
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 29 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -44,23 +44,18 @@ static void createInstanceConfig() {
static void createInstanceConfig(
String projectId, String baseInstanceConfig, String instanceConfigId) {
try (Spanner spanner =
SpannerOptions.newBuilder()
.setProjectId(projectId)
.build()
.getService()) {
SpannerOptions.newBuilder().setProjectId(projectId).build().getService()) {
final InstanceAdminClient instanceAdminClient = spanner.getInstanceAdminClient();
final InstanceConfig baseConfig = instanceAdminClient.getInstanceConfig(baseInstanceConfig);
List<ReplicaInfo> readOnlyReplicas = ImmutableList.of(baseConfig.getOptionalReplicas().get(0));

List<ReplicaInfo> readOnlyReplicas =
ImmutableList.of(baseConfig.getOptionalReplicas().get(0));
InstanceConfigInfo instanceConfigInfo =
InstanceConfig.newBuilder(InstanceConfigId.of(projectId, instanceConfigId), baseConfig)
.setDisplayName(instanceConfigId)
.addReadOnlyReplicas(readOnlyReplicas)
.build();

final OperationFuture<InstanceConfig, CreateInstanceConfigMetadata> operation =
instanceAdminClient.createInstanceConfig(instanceConfigInfo);

try {
System.out.printf("Waiting for create operation on %s to complete...\n", instanceConfigId);
InstanceConfig instanceConfig = operation.get(5, TimeUnit.MINUTES);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,8 @@ static void deleteInstanceConfig() {

static void deleteInstanceConfig(String projectId, String instanceConfigId) {
try (Spanner spanner =
SpannerOptions.newBuilder()
.setProjectId(projectId)
.build()
.getService()) {
SpannerOptions.newBuilder().setProjectId(projectId).build().getService()) {
final InstanceAdminClient instanceAdminClient = spanner.getInstanceAdminClient();

try {
System.out.printf("Waiting for delete operation on %s to complete...\n", instanceConfigId);
instanceAdminClient.deleteInstanceConfig(instanceConfigId);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,28 +34,26 @@ static void listInstanceConfigOperations() {

static void listInstanceConfigOperations(String projectId) {
try (Spanner spanner =
SpannerOptions.newBuilder()
.setProjectId(projectId)
.build()
.getService()) {
SpannerOptions.newBuilder().setProjectId(projectId).build().getService()) {
final InstanceAdminClient instanceAdminClient = spanner.getInstanceAdminClient();

try {
System.out.printf(
"Waiting for listing instance config operations on project %s to complete...\n",
projectId);
final Iterable<Operation> instanceConfigOperations =
instanceAdminClient.listInstanceConfigOperations(
Options.filter(
"(metadata.@type=type.googleapis.com/google.spanner.admin.instance.v1.CreateInstanceConfigMetadata)"))
instanceAdminClient
.listInstanceConfigOperations(
Options.filter(
"(metadata.@type=type.googleapis.com/"
+ "google.spanner.admin.instance.v1.CreateInstanceConfigMetadata)"))
.iterateAll();
for (Operation operation : instanceConfigOperations) {
CreateInstanceConfigMetadata metadata =
operation.getMetadata().unpack(CreateInstanceConfigMetadata.class);
System.out.printf(
"List instance config operation on %s is %d%% completed.\n",
metadata.getInstanceConfig().getName(),
metadata.getProgress().getProgressPercent());
metadata.getInstanceConfig().getName(), metadata.getProgress().getProgressPercent());
}
} catch (InvalidProtocolBufferException e) {
System.out.printf(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,23 +41,17 @@ static void updateInstanceConfig() {

static void updateInstanceConfig(String projectId, String instanceConfigId) {
try (Spanner spanner =
SpannerOptions.newBuilder()
.setProjectId(projectId)
.build()
.getService()) {
SpannerOptions.newBuilder().setProjectId(projectId).build().getService()) {
final InstanceAdminClient instanceAdminClient = spanner.getInstanceAdminClient();

InstanceConfigInfo instanceConfigInfo =
InstanceConfig.newBuilder(InstanceConfigId.of(projectId, instanceConfigId))
.setDisplayName("updated custom instance config")
.addLabel("updated", "true")
.build();

final OperationFuture<InstanceConfig, UpdateInstanceConfigMetadata> operation =
instanceAdminClient.updateInstanceConfig(
instanceConfigInfo,
ImmutableList.of(InstanceConfigField.DISPLAY_NAME, InstanceConfigField.LABELS));

try {
System.out.printf("Waiting for update operation on %s to complete...\n", instanceConfigId);
InstanceConfig instanceConfig = operation.get(5, TimeUnit.MINUTES);
Expand Down

0 comments on commit 274346d

Please sign in to comment.