Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent excessive string parsing when publishing and receiving messages to improve performance #2316

Closed
wants to merge 3 commits into from

Conversation

michaelpri10
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2295 ☕️

This modifies PR #2304, and adds the same logic for the subscribe path as well.

@michaelpri10 michaelpri10 requested a review from a team as a code owner January 24, 2025 01:11
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jan 24, 2025
Copy link

snippet-bot bot commented Jan 24, 2025

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@michaelpri10 michaelpri10 changed the title ix: Prevent excessive string parsing when publishing and receiving messages to improve performance fix: Prevent excessive string parsing when publishing and receiving messages to improve performance Jan 24, 2025
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/java-pubsub API. label Jan 24, 2025
@michaelpri10
Copy link
Contributor Author

Some issues setting up the PR here, will try again..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential (CPU) performance improvement when publishing
1 participant