Skip to content

Commit

Permalink
fix: fix dependency declaration to properly include runtime scope (#1238
Browse files Browse the repository at this point in the history
)

Change the scope of the following dependencies to runtime from test
* io.grpc:grpc-stub
* io.grpc:grpc-core
* com.google.http-client:google-http-client
  • Loading branch information
BenWhitehead authored Aug 5, 2022
1 parent 75e03c2 commit e9a4ce5
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions google-cloud-pubsub/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-stub</artifactId>
<scope>test</scope>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>io.grpc</groupId>
Expand Down Expand Up @@ -85,7 +85,7 @@
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-core</artifactId>
<scope>test</scope>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>com.google.errorprone</groupId>
Expand All @@ -98,7 +98,7 @@
<dependency>
<groupId>com.google.http-client</groupId>
<artifactId>google-http-client</artifactId>
<scope>test</scope>
<scope>runtime</scope>
</dependency>

<!-- Test dependencies -->
Expand Down Expand Up @@ -169,7 +169,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<version>3.3.0</version>
<configuration>
<ignoredUnusedDeclaredDependencies>
<ignoredUnusedDeclaredDependency>com.google.auth:google-auth-library-oauth2-http:jar</ignoredUnusedDeclaredDependency>
Expand Down

0 comments on commit e9a4ce5

Please sign in to comment.