-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update README #814
Merged
minherz
merged 3 commits into
minherz/structured_logging
from
minherz/structured_logging_readme
Jan 5, 2022
Merged
chore: update README #814
minherz
merged 3 commits into
minherz/structured_logging
from
minherz/structured_logging_readme
Jan 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: logging
Issues related to the googleapis/java-logging API.
label
Jan 2, 2022
losalex
suggested changes
Jan 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update instructions about manual context usage with samples about configuring inherited context.
product-auto-label
bot
added
size: s
Pull request size is small.
and removed
size: xs
Pull request size is extra small.
labels
Jan 3, 2022
minherz
force-pushed
the
minherz/structured_logging
branch
from
January 4, 2022 17:01
5f484a7
to
f9bda3d
Compare
losalex
approved these changes
Jan 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some extra comments - please take a look
google-cloud-logging/src/main/java/com/google/cloud/logging/LogEntry.java
Outdated
Show resolved
Hide resolved
google-cloud-logging/src/main/java/com/google/cloud/logging/LogEntry.java
Outdated
Show resolved
Hide resolved
google-cloud-logging/src/main/java/com/google/cloud/logging/LogEntry.java
Outdated
Show resolved
Hide resolved
google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingImpl.java
Outdated
Show resolved
Hide resolved
google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingImpl.java
Outdated
Show resolved
Hide resolved
add short description about automatic metadata population and redirection of JUL logs to stdout to README.
change the order of options to manage the context. describe configuration to enable inheriting context in child scopes (threads).
minherz
force-pushed
the
minherz/structured_logging_readme
branch
from
January 5, 2022 08:36
f9896ef
to
1f6f281
Compare
reverse the use of 'appendComma' flag rename populateMetadata? flags to make the logic clear
minherz
added a commit
that referenced
this pull request
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add short description about automatic metadata population and redirection of JUL logs to stdout to README.