feat: configure opt-out metada auto-population for JUL handler #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
losalex
reviewed
Dec 23, 2021
| @@ -417,4 +456,8 @@ private Logging getLogging() { | |||
| } | |||
| return logging; | |||
| } | |||
|
|
|||
| private static boolean isTrueOrNull(Boolean b) { | |||
There was a problem hiding this comment.
nit: Such methods ideally should accept additional variable with default value to be returned in case if checked parameter is null.
There was a problem hiding this comment.
It is not "getter". This method is used to answer the question whether the parameter is null or Boolean.TRUE.
There was a problem hiding this comment.
nit: I was kinda suggesting to make it "getter", so it can be reused later if needed
There was a problem hiding this comment.
There is "getter":
The above is a service method used at initialization only to enforce opt-out if one of the original sources of the configuration: LoggingOptions or config file has it set to FALSE. However, if the configuration is omitted then it should be interpreted as "allowed" according to the design requirement: to allow by default.
google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingHandler.java
Outdated
Show resolved
Hide resolved
google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingHandler.java
Show resolved
Hide resolved
adds metadata auto-population flag to JUL handler. adds metadata auto-population flag to logging config file. forwards metadata auto-population flag via WriteOption to write() calls. refactors JUL handler tests to remove duplication, unused calls and warnings
losalex
approved these changes
Dec 23, 2021
minherz
added a commit
that referenced
this pull request
Dec 30, 2021
Adds metadata auto-population flag to JUL handler. Adds metadata auto-population flag to logging config file. Forwards metadata auto-population flag via WriteOption to write() calls. Refactors JUL handler tests to remove duplication, unused calls and warnings
minherz
added a commit
that referenced
this pull request
Jan 4, 2022
Adds metadata auto-population flag to JUL handler. Adds metadata auto-population flag to logging config file. Forwards metadata auto-population flag via WriteOption to write() calls. Refactors JUL handler tests to remove duplication, unused calls and warnings
minherz
added a commit
that referenced
this pull request
Jan 5, 2022
Adds metadata auto-population flag to JUL handler. Adds metadata auto-population flag to logging config file. Forwards metadata auto-population flag via WriteOption to write() calls. Refactors JUL handler tests to remove duplication, unused calls and warnings
minherz
added a commit
that referenced
this pull request
Jan 7, 2022
…ogs redirection to stdout in JUL handler (#808) Aggregates the following work: - #821 - #812 - #807 - #803 - #798 Fixes #689, #691, #799 and #800 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to opt-out auto-population of the log entries with additional metadata in JUL handler using the flag in
LoggingOptionsandLoggingConfigconfiguration.Opt-out is set if at least one of the above will be set to
false. Absence of the configuration is interpreted same as setting the configuration totrue.