Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor retrieving resource metadata #716

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Conversation

minherz
Copy link
Contributor

@minherz minherz commented Oct 19, 2021

host logic for getting metadata values for monitored resource in MetadataLoader
refactor MonitoredResourceUitl to use MetadataLoader

Fixes #710

host logic for getting metadata values for monitored resource in MetadataLoader
refactor MonitoredResourceUitl to use MetadataLoader
@minherz minherz requested review from a team as code owners October 19, 2021 12:36
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 19, 2021
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Oct 19, 2021
@minherz minherz requested a review from simonz130 October 19, 2021 12:37
@simonz130 simonz130 assigned minherz and unassigned simonz130 Oct 19, 2021
Copy link

@simonz130 simonz130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much better now! Thanks for this refactoring!

@minherz minherz merged commit e273856 into main Oct 20, 2021
@minherz minherz deleted the minherz/fix-710 branch October 20, 2021 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

structured logging: refactor logic of MonitoredResourceUtil#getValue() to avoid long switch
2 participants