Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(.github): Update java issues and prs assignee #1494

Closed
wants to merge 3 commits into from

Conversation

cindy-peng
Copy link
Contributor

@cindy-peng cindy-peng commented Dec 6, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️
This is to update the PR and issue auto-assignees to api-logging-java-reviewers group.

If you write sample code, please follow the samples format.

@cindy-peng cindy-peng requested review from a team as code owners December 6, 2023 20:11
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: logging Issues related to the googleapis/java-logging API. labels Dec 6, 2023
@cindy-peng cindy-peng changed the title chore(.github): Update winston issues and prs assignee chore(.github): Update java issues and prs assignee Dec 6, 2023
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Dec 6, 2023
@cindy-peng cindy-peng closed this Dec 13, 2023
@cindy-peng cindy-peng reopened this Dec 13, 2023
@cindy-peng cindy-peng added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2023
Copy link
Contributor

@gkevinzheng gkevinzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you separate out the blunderbuss changes into a PR separate from the library versioning changes? Otherwise LGTM.

@cindy-peng
Copy link
Contributor Author

cindy-peng commented Dec 14, 2023

Could you separate out the blunderbuss changes into a PR separate from the library versioning changes? Otherwise LGTM.

Yea looks like owlbot auto-committed an update in the same PR. @gkevinzheng Here is the new one:
#1497

@cindy-peng cindy-peng closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants