Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make LoggingHandler.logEntryFor extensible #1021

Merged
merged 2 commits into from
Aug 19, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -51,20 +51,20 @@ If you are using Maven without BOM, add this to your dependencies:
If you are using Gradle 5.x or later, add this to your dependencies:

```Groovy
implementation platform('com.google.cloud:libraries-bom:26.0.0')
implementation platform('com.google.cloud:libraries-bom:26.1.0')

implementation 'com.google.cloud:google-cloud-logging'
```
If you are using Gradle without BOM, add this to your dependencies:

```Groovy
implementation 'com.google.cloud:google-cloud-logging:3.10.0'
implementation 'com.google.cloud:google-cloud-logging:3.10.2'
```

If you are using SBT, add this to your dependencies:

```Scala
libraryDependencies += "com.google.cloud" % "google-cloud-logging" % "3.10.0"
libraryDependencies += "com.google.cloud" % "google-cloud-logging" % "3.10.2"
```

## Authentication
Original file line number Diff line number Diff line change
@@ -305,7 +305,7 @@ public void publish(LogRecord record) {
}
LogEntry logEntry;
try {
logEntry = logEntryFor(record);
logEntry = logEntryFor(record).build();
} catch (Exception ex) {
getErrorManager().error(null, ex, ErrorManager.FORMAT_FAILURE);
return;
@@ -343,7 +343,7 @@ private MonitoredResource getMonitoredResource() {
return null;
}

private LogEntry logEntryFor(LogRecord record) throws Exception {
protected LogEntry.Builder logEntryFor(LogRecord record) throws Exception {
String payload = getFormatter().format(record);
Level level = record.getLevel();
LogEntry.Builder builder =
@@ -360,7 +360,7 @@ private LogEntry logEntryFor(LogRecord record) throws Exception {
for (LoggingEnhancer enhancer : enhancers) {
enhancer.enhanceLogEntry(builder);
}
return builder.build();
return builder;
}

@Override