Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix batch regression for branch Java7 #744

Closed
minherz opened this issue Nov 13, 2021 · 0 comments
Closed

Fix batch regression for branch Java7 #744

minherz opened this issue Nov 13, 2021 · 0 comments
Assignees
@minherz
Labels
api: logging Issues related to the googleapis/java-logging API. lang: java Issues specific to Java. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@minherz
Copy link
Contributor

minherz commented Nov 13, 2021

Apply the fix for batch regression made in #726 to Java7 branch.
@minherz minherz added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: logging Issues related to the googleapis/java-logging API. lang: java Issues specific to Java. labels Nov 13, 2021
@minherz minherz self-assigned this Nov 13, 2021
minherz added a commit that referenced this issue Nov 22, 2021
@minherz
fix: restore batching for writeLogEntriesCallable
befa729 
fix regression which caused to writeLogEntriesCallable stub
to use non aggregated gax method.

Fix: #744
@minherz minherz mentioned this issue Nov 22, 2021
Merged
minherz added a commit that referenced this issue Nov 22, 2021
@minherz
fix: restore batching for writeLogEntriesCallable (#754)
9b92d0a 
handle regression which caused to writeLogEntriesCallable stub to use non aggregated gax method.

Fixes #744
@minherz minherz closed this as completed Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@minherz minherz

Labels
api: logging Issues related to the googleapis/java-logging API. lang: java Issues specific to Java. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@minherz