Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement user friendly interface for listLogs API #593

Closed
minherz opened this issue Jul 27, 2021 · 0 comments · Fixed by #602
Closed

feat: Implement user friendly interface for listLogs API #593

minherz opened this issue Jul 27, 2021 · 0 comments · Fixed by #602
Assignees
Labels
api: logging Issues related to the googleapis/java-logging API. lang: java Issues specific to Java. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@minherz
Copy link
Contributor

minherz commented Jul 27, 2021

Is your feature request related to a problem? Please describe.
It is hard and contra-intuitive to use auto-generated implementation of the grpc or REST APIs. The Java logging client library is missing list logs implementation.

Describe the solution you'd like
I would like to have listLogs interface implemented in a similar way as other interfaces (e.g. listSinks).

Describe alternatives you've considered
An alternative would be to use auto-generated API classes such as com.google.logging.v2.ListLogsRequest.

Additional context
None

@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Jul 27, 2021
@minherz minherz added lang: java Issues specific to Java. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jul 27, 2021
@minherz minherz assigned minherz and unassigned simonz130 Jul 27, 2021
minherz added a commit that referenced this issue Jul 30, 2021
Add listLogs API support to hand-written layer of google-cloud-logging.
Add unit testing for the new listLogs API.

Fixes #593
minherz added a commit that referenced this issue Aug 8, 2021
Add listLogs API support to hand-written layer of google-cloud-logging.
Add unit testing for the new listLogs API.

Fixes #593
minherz added a commit that referenced this issue Aug 11, 2021
Add listLogs API support to hand-written layer of google-cloud-logging.
Add unit testing for the new listLogs API.

Fixes #593
minherz added a commit that referenced this issue Aug 12, 2021
Add listLogs API support to hand-written layer of google-cloud-logging.
Add unit testing for the new listLogs API.

Fixes #593
minherz added a commit that referenced this issue Aug 12, 2021
* feat: add listLogs and listLogsAsync to Logging

Add listLogs API support to hand-written layer of google-cloud-logging.
Add unit testing for the new listLogs API.

Fixes #593

* feat: add listLogs snippet example

Add a sample snippet to demonstrate use of listLogs API.
Refactor ListLogs to include snippets for listLogs and listLogEntries.
Format all snippets.

Fixes #358.

* chore: set generated serialVersionUID for LogNamePageFetcher

* chore(code): fixing errors

* chore(deps): fix clirr plugin 7012 error

Because of JDK 1.7 it is impossible to provide default implementation
for new interface methods.
File with exclusions is added instead. The file should be removed once
JDK version is upgraded.

* chore(tests): fix samples' tests

Fix printed string in LogEntryWriteHttpRequest.createLogEntryRequest().
Fix loops to wait for any data in STDOUT.
Add test for listLogs snippet.

* chore(test): forward exception throwing

Update testListLogNames() signature to throw exceptions

* chore(tests): refactoring tests

Test ListLogs.printLogNames vs audit logs to save time.
Restore retrieval of log entries in the wait loop to ensure printing to STDOUT

* chore(tests): fine tune clirr exceptions

Provide method level exception configuration in clirr-ignored-differences.
Implement default methods for new methods in Logging and LoggingRpc interfaces.
Following guidelines, remove serialVersionUID from LogNamePageFetcher.

* chore: refactoring method naming and sample snippets

Make more verbose naming for methods.
Refactor testing after renaming interface method(s).
Split ListLogs sample into two: ListLogEntries and ListLogs.

* chore(fix): fix formatting

* chore(comment): fix copyright year of the new file

* chore(fix): restore sample filter to list log entries

update the list log entries filter to bring results only for the last hour.

* chore(fix): fix snippet-bot errors

adding empty region tag logging_list_log_entries to ListLogs.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API. lang: java Issues specific to Java. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants