-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add graal native image profile for logback library #1246
Conversation
Warning: This pull request is touching the following templated files:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm after nit!
<profile> | ||
<id>native</id> | ||
<properties> | ||
<test>!LoggingAppenderTest</test> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please re-add the comment that was in the build.sh
file about why we're skipping this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please re-add the comment that was in the
build.sh
file about why we're skipping this
Good feedback! Added the comment.
…java-logging-logback into cindy/native-profile
🤖 I have created a release *beep* *boop* --- ## [0.131.0-alpha](https://togithub.com/googleapis/java-logging-logback/compare/v0.130.30-alpha...v0.131.0-alpha) (2024-01-25) ### Features * Add graal native image profile for logback library ([#1246](https://togithub.com/googleapis/java-logging-logback/issues/1246)) ([ab58b88](https://togithub.com/googleapis/java-logging-logback/commit/ab58b887d041783335d2ab4f04b47651ae91ef77)) ### Dependencies * Update dependency com.google.cloud:google-cloud-logging to v3.15.16 ([#1257](https://togithub.com/googleapis/java-logging-logback/issues/1257)) ([28c23f6](https://togithub.com/googleapis/java-logging-logback/commit/28c23f67f827c42ad4790fd7f9122d227daa3a8d)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.22.0 ([#1250](https://togithub.com/googleapis/java-logging-logback/issues/1250)) ([730c46c](https://togithub.com/googleapis/java-logging-logback/commit/730c46cbd6f59f9d370eb6a10b5dd00d58ca0506)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.23.0 ([#1256](https://togithub.com/googleapis/java-logging-logback/issues/1256)) ([df7800b](https://togithub.com/googleapis/java-logging-logback/commit/df7800bb5205ad4cecc0a44ccbde8141174063ad)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1077 ☕️
If you write sample code, please follow the samples format.