Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(.github): Update logback issues and prs assignee #1227

Closed
wants to merge 2 commits into from
Closed

chore(.github): Update logback issues and prs assignee #1227

wants to merge 2 commits into from

Conversation

cindy-peng
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️
This is to update the PR and issue auto-assignees to api-logging-java-reviewers group.

If you write sample code, please follow the samples format.

@cindy-peng cindy-peng requested review from a team as code owners December 6, 2023 20:14
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: logging Issues related to the googleapis/java-logging-logback API. labels Dec 6, 2023
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Dec 6, 2023
gkevinzheng
gkevinzheng reviewed Dec 14, 2023
View reviewed changes
Copy link

@gkevinzheng gkevinzheng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move the PR assignee to another PR? Otherwise LGTM.

@cindy-peng
Copy link
Contributor Author

Could you move the PR assignee to another PR? Otherwise LGTM.

Could you move the PR assignee to another PR? Otherwise LGTM.

Hi @gkevinzheng , this is the new PR separating out the changes: #1229

@cindy-peng cindy-peng closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkevinzheng gkevinzheng gkevinzheng left review comments

Assignees

@daniel-sanche daniel-sanche

Labels
api: logging Issues related to the googleapis/java-logging-logback API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cindy-peng @gkevinzheng @daniel-sanche