Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update BulkWriter.delete() to return sentinel value #250

Closed
wants to merge 1 commit into from
Closed

fix: update BulkWriter.delete() to return sentinel value #250

wants to merge 1 commit into from

Conversation

thebrianchen
Copy link

Porting from node.

Will port integration tests in a separate PR.

@thebrianchen thebrianchen self-assigned this Jun 11, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 11, 2020
@thebrianchen thebrianchen changed the base branch from master to bc/bulk-master June 11, 2020 00:18
@thebrianchen thebrianchen changed the title fix: update BulkWriter.delete() to return sentinel value. fix: update BulkWriter.delete() to return sentinel value Jun 11, 2020
@thebrianchen thebrianchen added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2020
@thebrianchen
Copy link
Author

Closing b/c for some reason tests are stuck after setting the wrong base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thebrianchen thebrianchen

Labels
cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thebrianchen @googlebot