-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mark v1beta1 as deprecated #154
Merged
schmidt-sebastian
merged 10 commits into
googleapis:master
from
schmidt-sebastian:mrschmidt/deprecate
Mar 27, 2020
Merged
fix: mark v1beta1 as deprecated #154
schmidt-sebastian
merged 10 commits into
googleapis:master
from
schmidt-sebastian:mrschmidt/deprecate
Mar 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Fork
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Mar 26, 2020
schmidt-sebastian
changed the title
Mrschmidt/deprecate
fix: mark v1beta1 as deprecated
Mar 26, 2020
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
============================================
+ Coverage 71.62% 72.25% +0.63%
- Complexity 969 978 +9
============================================
Files 62 62
Lines 5222 5222
Branches 579 579
============================================
+ Hits 3740 3773 +33
+ Misses 1302 1268 -34
- Partials 180 181 +1
Continue to review full report at Codecov.
|
BenWhitehead
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to discourage use of the v1beta1 protocol.
Port of googleapis/nodejs-firestore#937