Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Thread safe UpdateBuilder #1537

Merged
merged 23 commits into from
Jan 24, 2024
Merged

fix: Thread safe UpdateBuilder #1537

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
138ebb8
Thread safe UpdateBuilder
tom-andersen Jan 19, 2024
facf7cf
Add comment
tom-andersen Jan 19, 2024
bb0bf77
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 19, 2024
a306c0e
chore: add an unmanaged dependency check (#1532)
JoeWang1127 Jan 19, 2024
763cdf5
refactor: Optimize FieldMask instantiation (#1536)
tom-andersen Jan 19, 2024
96175e3
Use synchronize
tom-andersen Jan 22, 2024
c790513
Merge remote-tracking branch 'origin/main' into tomandersen/threadSaf…
tom-andersen Jan 22, 2024
8967cb7
Update comment
tom-andersen Jan 22, 2024
7b3f9a8
Make sure commit prevents writes.
tom-andersen Jan 22, 2024
2e66019
Pretty
tom-andersen Jan 22, 2024
17a7ae6
Refactor
tom-andersen Jan 22, 2024
ae56dec
Add comments and make committed volatile.
tom-andersen Jan 23, 2024
81002e0
Make WriteOperation immutable.
tom-andersen Jan 23, 2024
b2ff585
Refactor
tom-andersen Jan 23, 2024
5cb6c52
fix(deps): Update the Java code generator (gapic-generator-java) to 2…
gcf-owl-bot[bot] Jan 22, 2024
bcc366d
test(deps): update dependency com.google.truth:truth to v1.3.0 (#1538)
renovate-bot Jan 22, 2024
396c15f
make some methods static: applyFieldMask() and convertToFieldPaths()
dconeybe Jan 23, 2024
e1c701a
Comment
tom-andersen Jan 23, 2024
b54f0d0
Inline
tom-andersen Jan 23, 2024
f6cc718
use explicit synchronization
dconeybe Jan 23, 2024
917e473
Merge remote-tracking branch 'origin/main' into tomandersen/threadSaf…
dconeybe Jan 23, 2024
a885696
Review feedback
tom-andersen Jan 24, 2024
e010693
Merge remote-tracking branch 'origin/tomandersen/threadSafeUpdateBuil…
tom-andersen Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion google-cloud-firestore/src/main/java/com/google/cloud/firestore/UpdateBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
import java.util.Map.Entry;
import java.util.SortedSet;
import java.util.TreeSet;
import java.util.concurrent.CopyOnWriteArrayList;
import javax.annotation.Nonnull;
import javax.annotation.Nullable;

Expand All @@ -62,7 +63,7 @@ public String toString() {

final FirestoreImpl firestore;

private final List<WriteOperation> writes = new ArrayList<>();
private final List<WriteOperation> writes = new CopyOnWriteArrayList<>();

protected boolean committed;

Expand Down