chore: remodel unary callables as server streaming callables with an adapter at the end #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adapter at the end Change-Id: I8708dff0e192d7647ef2cb361fc0992e1ddd2b24
Change-Id: Id4c56656a829f5f4c7ab1170f5f980cf3cc3760c
product-auto-label
bot
added
size: l
Change-Id: I6afe36b01aedab6820adee7f898923e7351bbad4
Change-Id: I1c45f2058cadc1acb9c6abd87222be9eb233778c
Change-Id: I4e05efaac6ae60f5827c6d666c3c6f6cebebaa54
Change-Id: I654e70f0b34f5d4c3071ba3c2fed64ea183a865e
Change-Id: Ic0106f3c6983edbb032aeba6e107e4324952397d
Change-Id: I4f44969807632678e3c22324967548d9b9ee5bfa
Change-Id: I8d8474050e40cd819d3be2a5b251448f6eb8c94f
Change-Id: I4504c47143000d97554a96469d5f3fd368d08ef1
…r not the next Change-Id: I16a35e19c50b7b7b855f4299cf41f0607b3e90bd
mutianf
reviewed
Nov 5, 2024
...ble/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableUnaryOperationCallable.java
Show resolved
Hide resolved
...ble/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableUnaryOperationCallable.java
Show resolved
Hide resolved
| public void onStart(StreamController controller) { | ||
| this.controller = controller; | ||
| controller.disableAutoInboundFlowControl(); | ||
| // Request 2 to detect protocol bugs |
There was a problem hiding this comment.
to preserve the current behavior
There was a problem hiding this comment.
...ble/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableUnaryOperationCallable.java
Show resolved
Hide resolved
...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java
Outdated
Show resolved
Hide resolved
...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java
Show resolved
Hide resolved
...rc/main/java/com/google/cloud/bigtable/data/v2/stub/TransformingServerStreamingCallable.java
Show resolved
Hide resolved
Change-Id: I4522719a65f24d27fb9dccde031c3b1cc04042c2
mutianf
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to decouple payload and trailer handling.