Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve logging in safe response observer #2397

Merged
merged 1 commit into from
Nov 4, 2024
Merged

chore: improve logging in safe response observer #2397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...d-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/SafeResponseObserver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public final void onResponse(ResponseT response) {
@Override
public final void onError(Throwable throwable) {
if (!isClosed.compareAndSet(false, true)) {
logException("Received error after the stream is closed");
logException("Received error after the stream is closed", throwable);
return;
}

Expand Down Expand Up @@ -113,6 +113,10 @@ private void logException(String message) {
LOGGER.log(Level.WARNING, message, new IllegalStateException(message));
}

private void logException(String message, Throwable cause) {
LOGGER.log(Level.WARNING, message, new IllegalStateException(message, cause));
}

protected abstract void onStartImpl(StreamController streamController);

protected abstract void onResponseImpl(ResponseT response);
Expand Down
Loading