Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: [no need to review] Kokoro build experiment with key #1952

Closed
wants to merge 4 commits into from

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Oct 5, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@suztomo suztomo requested review from a team as code owners October 5, 2023 14:35
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Oct 5, 2023
@suztomo
Copy link
Member Author

suztomo commented Oct 5, 2023

@suztomo
Copy link
Member Author

suztomo commented Oct 5, 2023

It seems working http://fusion2/ci/kokoro/prod:cloud-devrel%2Fclient-libraries%2Fjava%2Fjava-bigtable%2Fpresubmit%2Fintegration/activity/49a23571-fcaf-4ba6-94fb-779c61c956fc/log

...
env_vars {
  key: "INTEGRATION_TEST_ARGS"
  value: "-P bigtable-emulator-it,bigtable-prod-it,bigtable-prod-batch-it -Dbigtable.project=gcloud-devel -Dbigtable.instance=google-cloud-bigtable -Dbigtable.table=integration-tests -Dbigtable.kms_key_name=projects/gcloud-devel/locations/us-east1/keyRings/cmek-test-key-ring/cryptoKeys/cmek-test-key -Dbigtable.wait-for-cmek-key-status=true"
}
env_vars {
  key: "JOB_TYPE"
  value: "integration"
}
...

@suztomo suztomo marked this pull request as draft October 5, 2023 14:40
@suztomo
Copy link
Member Author

suztomo commented Oct 5, 2023

Let's intentionally break the build by injecting wrong value.

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Oct 5, 2023
@suztomo
Copy link
Member Author

suztomo commented Oct 5, 2023

It worked. http://fusion2/ci/kokoro/prod:cloud-devrel%2Fclient-libraries%2Fjava%2Fjava-bigtable%2Fpresubmit%2Fintegration/activity/8dc916e0-c486-4311-ae39-dbff143e52a2/log

...
env_vars {
  key: "INTEGRATION_TEST_ARGS"
  value: "-P bigtable-emulator-it,bigtable-prod-it,bigtable-prod-batch-it -Dbigtable.project=gcloud-devel -Dbigtable.instance=google-cloud-bigtable -Dbigtable.table=integration-tests -Dbigtable.kms_key_name=projects/gcloud-devel/locations/us-east1/keyRings/cmek-test-key-ring/cryptoKeys/cmek-test-key -Dbigtable.wait-for-cmek-key-status=true"
}
env_vars {
  key: "JOB_TYPE"
  value: "invalid-value-test"
}
...

The behavior seems to pick the last one.

@suztomo
Copy link
Member Author

suztomo commented Oct 5, 2023

http://fusion2/ci/kokoro/prod%3Acloud-devrel%2Fclient-libraries%2Fjava%2Fjava-bigtable%2Fpresubmit%2Fintegration/activity/b4dc99f8-b5ee-46db-9cae-0e378b167b5d :

...
env_vars {
  key: "GCLOUD_PROJECT"
  value: "no-such-project-value1"
}
env_vars {
  key: "GOOGLE_APPLICATION_CREDENTIALS"
  value: "secret_manager/java-it-service-account"
}
env_vars {
  key: "GOOGLE_CLOUD_PROJECT"
  value: "no-such-project-value2"
}
...

@suztomo
Copy link
Member Author

suztomo commented Oct 5, 2023

It unexpectedly succeeded:

env_vars {
  key: "GOOGLE_CLOUD_PROJECT"
  value: "no-such-project-value2"
}
env_vars {
  key: "INTEGRATION_TEST_ARGS"
  value: "-P bigtable-emulator-it,bigtable-prod-it,bigtable-prod-batch-it -Dbigtable.project=gcloud-devel -Dbigtable.instance=google-cloud-bigtable -Dbigtable.table=integration-tests -Dbigtable.kms_key_name=projects/gcloud-devel/locations/us-east1/keyRings/cmek-test-key-ring/cryptoKeys/cmek-test-key -Dbigtable.wait-for-cmek-key-status=true"
}

Maybe -Dbigtable.project=gcloud-devel supercedes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants