Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: make delete examples consistent with other languages #1710

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

billyjacobson
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@billyjacobson billyjacobson requested a review from kolea2 April 13, 2023 19:13
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Apr 13, 2023
@snippet-bot
Copy link

snippet-bot bot commented Apr 13, 2023

Here is the summary of changes.

You are about to add 3 region tags.
You are about to delete 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Apr 13, 2023
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners April 13, 2023 19:16
Copy link
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with one suggestion

@billyjacobson billyjacobson added the automerge Merge the pull request once unit tests and other checks pass. label Apr 13, 2023
@billyjacobson billyjacobson merged commit 2d80188 into main Apr 13, 2023
@billyjacobson billyjacobson deleted the delete-example-consistency branch April 13, 2023 19:43
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 13, 2023
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 17, 2023
🤖 I have created a release *beep* *boop*
---


## [2.20.4](https://togithub.com/googleapis/java-bigtable/compare/v2.20.3...v2.20.4) (2023-04-17)


### Documentation

* Make delete examples consistent with other languages ([#1710](https://togithub.com/googleapis/java-bigtable/issues/1710)) ([2d80188](https://togithub.com/googleapis/java-bigtable/commit/2d80188c65f454e037b758426b8747b5992db0de))


### Dependencies

* Update actions/setup-go action to v4 ([#1700](https://togithub.com/googleapis/java-bigtable/issues/1700)) ([1fd13ba](https://togithub.com/googleapis/java-bigtable/commit/1fd13ba9fdfa0322ee419f405c92ebe3979d85c7))
* Update dependency com.google.cloud:google-cloud-monitoring-bom to v3.16.0 ([#1712](https://togithub.com/googleapis/java-bigtable/issues/1712)) ([f3bb088](https://togithub.com/googleapis/java-bigtable/commit/f3bb088cd670805e5c6975e7154ee7e1e320acc6))
* Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.21 ([#1704](https://togithub.com/googleapis/java-bigtable/issues/1704)) ([d60c946](https://togithub.com/googleapis/java-bigtable/commit/d60c94630f60d01241eecf9e3061ed197435b55e))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.21 ([#1705](https://togithub.com/googleapis/java-bigtable/issues/1705)) ([8f3d69d](https://togithub.com/googleapis/java-bigtable/commit/8f3d69d2498a7c0b5f760a40054e17d07502764d))
* Update shared dependencies ([#1703](https://togithub.com/googleapis/java-bigtable/issues/1703)) ([076b411](https://togithub.com/googleapis/java-bigtable/commit/076b411b3c834c4ed1b98551f08befab78743c8f))
* Upgrade maven-enforcer-plugin to 3.3.0, remove duplicate entry in pom ([#1702](https://togithub.com/googleapis/java-bigtable/issues/1702)) ([392fc69](https://togithub.com/googleapis/java-bigtable/commit/392fc697b9b75d172ba5bfd98ead45a6074c47f7))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants