-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: if new_partitions is size 0, do not enforce size check #1673
fix: if new_partitions is size 0, do not enforce size check #1673
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Change-Id: I4e9b6507ff63df9f9ec9d57a0fc34e68e16f6e30
d905e4f
to
549e495
Compare
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
🤖 I have created a release *beep* *boop* --- ## [2.20.1](https://togithub.com/googleapis/java-bigtable/compare/v2.20.0...v2.20.1) (2023-03-21) ### Bug Fixes * If new_partitions is size 0, do not enforce size check ([#1673](https://togithub.com/googleapis/java-bigtable/issues/1673)) ([07bcfd9](https://togithub.com/googleapis/java-bigtable/commit/07bcfd9a0967f781fb8e5e0d764654dbf7bcda91)) ### Dependencies * Update dependency com.google.cloud:google-cloud-monitoring-bom to v3.14.0 ([#1668](https://togithub.com/googleapis/java-bigtable/issues/1668)) ([06f9615](https://togithub.com/googleapis/java-bigtable/commit/06f96156705a2a7897a31d11dad864afe94de693)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.5.0 ([#1670](https://togithub.com/googleapis/java-bigtable/issues/1670)) ([74cebf3](https://togithub.com/googleapis/java-bigtable/commit/74cebf3a5ab58f3fd3ae95583ba2421b733deda8)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Do not enforce new_partitions and change_stream_continuation_tokens to be the same size if new_partitions has size of 0 because Cloud Bigtable backend may not be updated to serve new_partitions field yet.
new_partitions
is a new field and the backend may not be serving this field.Change-Id: Id21c293b92c304f05b905ca8e8b3988b9241866e
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.