Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): fix flaky test #1633

Merged
merged 5 commits into from
Feb 16, 2023
Merged

fix(test): fix flaky test #1633

merged 5 commits into from
Feb 16, 2023

Conversation

igorbernstein2
Copy link
Contributor

The expectation list needs to be thread safe as it could be accessed from multiple grpc server threads

Change-Id: I74be5cd433fc31963b1c22091216dffa1ef9c55e

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@igorbernstein2
fix(test): fix flaky test
3d23de0 
The expectation list needs to be thread safe as it could be accessed from multiple grpc server threads

Change-Id: I74be5cd433fc31963b1c22091216dffa1ef9c55e
@igorbernstein2 igorbernstein2 requested a review from a team as a code owner February 16, 2023 15:33
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Feb 16, 2023
@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 16, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 16, 2023
@mutianf mutianf added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 16, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 16, 2023
@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 16, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 16, 2023
@mutianf mutianf merged commit fc29cd3 into main Feb 16, 2023
@mutianf mutianf deleted the fix-test branch February 16, 2023 16:06
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 16, 2023
@release-please release-please bot mentioned this pull request Feb 16, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 16, 2023
@release-please
chore(main): release 2.19.1 (#1629)
0b6f687 
🤖 I have created a release *beep* *boop*
---


## [2.19.1](https://togithub.com/googleapis/java-bigtable/compare/v2.19.0...v2.19.1) (2023-02-16)


### Bug Fixes

* Change the return type of Heartbeat::getEstimatedLowWatermark to long ([#1631](https://togithub.com/googleapis/java-bigtable/issues/1631)) ([a101494](https://togithub.com/googleapis/java-bigtable/commit/a101494909226114fd951c94348878bf38453793))
* Fix connectivity error count calculation ([#1632](https://togithub.com/googleapis/java-bigtable/issues/1632)) ([0803785](https://togithub.com/googleapis/java-bigtable/commit/0803785694874001a6ffbfe3245e84a23cb905ae))
* **test:** Fix flaky test ([#1633](https://togithub.com/googleapis/java-bigtable/issues/1633)) ([fc29cd3](https://togithub.com/googleapis/java-bigtable/commit/fc29cd35101fd6a6262aea8648bc06bd20ce3d10))


### Dependencies

* Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.20 ([#1626](https://togithub.com/googleapis/java-bigtable/issues/1626)) ([0865023](https://togithub.com/googleapis/java-bigtable/commit/08650238a806367c94072b51029010272c966148))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.20 ([#1627](https://togithub.com/googleapis/java-bigtable/issues/1627)) ([782e81f](https://togithub.com/googleapis/java-bigtable/commit/782e81f6e64c1d8015fddf2219d590c77217584d))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutianf mutianf mutianf approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorbernstein2 @mutianf