test(fix): update the test proxy to set app profile id and connect to emulator correctly #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
mutianf
approved these changes
Nov 21, 2022
test-proxy/src/main/java/com/google/cloud/bigtable/testproxy/CbtTestProxy.java
Outdated
Show resolved
Hide resolved
|
Please update the commit message and the name of the pr to be: fix: Update the test proxy to accommodate custom app profile and emulator #1529 |
liujiongxin
changed the title
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
liujiongxin
force-pushed
the
fix_proxy
branch
from
edb1803 to
343055e
Compare
liujiongxin
changed the title
liujiongxin
force-pushed
the
fix_proxy
branch
from
343055e to
b502d0a
Compare
Can we prefix these as |
liujiongxin
changed the title
… emulator correctly
liujiongxin
force-pushed
the
fix_proxy
branch
from
b502d0a to
4ec84b2
Compare
mutianf
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
mutianf
added
the
automerge
liujiongxin
added
the
kokoro:run
mutianf
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the test proxy work with the hermetic testing that exercises app_profile_id and emulator (https://github.com/googleapis/cloud-bigtable-clients-test)