Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix metric client settings #1509

Merged
merged 3 commits into from
Nov 9, 2022
Merged

fix: fix metric client settings #1509

merged 3 commits into from
Nov 9, 2022

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Nov 9, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@mutianf mutianf requested a review from a team as a code owner November 9, 2022 15:57
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Nov 9, 2022
@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 9, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 9, 2022
@mutianf mutianf added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 9, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 9, 2022
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner November 9, 2022 17:46
@mutianf mutianf merged commit 38ac115 into googleapis:main Nov 9, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 9, 2022
@mutianf mutianf deleted the fix-settings branch November 9, 2022 18:35
@release-please release-please bot mentioned this pull request Nov 11, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 11, 2022
@release-please
chore(main): release 2.16.0 (#1512)
dddb50d 
🤖 I have created a release *beep* *boop*
---


## [2.16.0](https://togithub.com/googleapis/java-bigtable/compare/v2.15.1...v2.16.0) (2022-11-11)


### Features

* Remove proto ReadEfficiencyStats ([#1455](https://togithub.com/googleapis/java-bigtable/issues/1455)) ([f6b243d](https://togithub.com/googleapis/java-bigtable/commit/f6b243db39c0370f0d9a4e47e553cfe62493b240))


### Bug Fixes

* Fix metric client settings ([#1509](https://togithub.com/googleapis/java-bigtable/issues/1509)) ([38ac115](https://togithub.com/googleapis/java-bigtable/commit/38ac115af07432e9c178064b59729a0b358105cd))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mutianf @igorbernstein2