Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: publish the RequestStats proto #1400

Merged
merged 5 commits into from
Sep 28, 2022
Merged

feat: publish the RequestStats proto #1400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d5fa6a5
docs: Remove unnecessary comment
gcf-owl-bot[bot] Sep 16, 2022
fc452ed
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Sep 16, 2022
aea9d2c
feat: publish the RequestStats proto
gcf-owl-bot[bot] Sep 23, 2022
ec9fb5b
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Sep 23, 2022
c7c4a6a
add to clirr ignored differences
kolea2 Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ If you are using Maven without BOM, add this to your dependencies:
If you are using Gradle 5.x or later, add this to your dependencies:

```Groovy
implementation platform('com.google.cloud:libraries-bom:26.1.1')
implementation platform('com.google.cloud:libraries-bom:26.1.2')

implementation 'com.google.cloud:google-cloud-bigtable'
```
Expand Down
3 changes: 1 addition & 2 deletions ...gtable/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,8 +922,7 @@ public final UnaryCallable<GetTableRequest, Table> getTableCallable() {
* }</pre>
*
* @param table Required. The table to update. The table's `name` field is used to identify the
* table to update. Format:
* `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]&#42;`
* table to update.
* @param updateMask Required. The list of fields to update. A mask specifying which fields (e.g.
* `deletion_protection`) in the `table` field should be updated. This mask is relative to the
* `table` field, not to the request message. The wildcard (&#42;) path is currently not
Expand Down
24 changes: 0 additions & 24 deletions ...loud-bigtable-admin-v2/src/main/java/com/google/bigtable/admin/v2/UpdateTableRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,6 @@ public static final com.google.protobuf.Descriptors.Descriptor getDescriptor() {
* <pre>
* Required. The table to update.
* The table's `name` field is used to identify the table to update.
* Format:
* `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
* </pre>
*
* <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
Expand All @@ -162,8 +160,6 @@ public boolean hasTable() {
* <pre>
* Required. The table to update.
* The table's `name` field is used to identify the table to update.
* Format:
* `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
* </pre>
*
* <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
Expand All @@ -181,8 +177,6 @@ public com.google.bigtable.admin.v2.Table getTable() {
* <pre>
* Required. The table to update.
* The table's `name` field is used to identify the table to update.
* Format:
* `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
* </pre>
*
* <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
Expand Down Expand Up @@ -633,8 +627,6 @@ public Builder mergeFrom(
* <pre>
* Required. The table to update.
* The table's `name` field is used to identify the table to update.
* Format:
* `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
* </pre>
*
* <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
Expand All @@ -651,8 +643,6 @@ public boolean hasTable() {
* <pre>
* Required. The table to update.
* The table's `name` field is used to identify the table to update.
* Format:
* `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
* </pre>
*
* <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
Expand All @@ -673,8 +663,6 @@ public com.google.bigtable.admin.v2.Table getTable() {
* <pre>
* Required. The table to update.
* The table's `name` field is used to identify the table to update.
* Format:
* `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
* </pre>
*
* <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
Expand All @@ -699,8 +687,6 @@ public Builder setTable(com.google.bigtable.admin.v2.Table value) {
* <pre>
* Required. The table to update.
* The table's `name` field is used to identify the table to update.
* Format:
* `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
* </pre>
*
* <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
Expand All @@ -722,8 +708,6 @@ public Builder setTable(com.google.bigtable.admin.v2.Table.Builder builderForVal
* <pre>
* Required. The table to update.
* The table's `name` field is used to identify the table to update.
* Format:
* `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
* </pre>
*
* <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
Expand All @@ -750,8 +734,6 @@ public Builder mergeTable(com.google.bigtable.admin.v2.Table value) {
* <pre>
* Required. The table to update.
* The table's `name` field is used to identify the table to update.
* Format:
* `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
* </pre>
*
* <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
Expand All @@ -774,8 +756,6 @@ public Builder clearTable() {
* <pre>
* Required. The table to update.
* The table's `name` field is used to identify the table to update.
* Format:
* `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
* </pre>
*
* <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
Expand All @@ -792,8 +772,6 @@ public com.google.bigtable.admin.v2.Table.Builder getTableBuilder() {
* <pre>
* Required. The table to update.
* The table's `name` field is used to identify the table to update.
* Format:
* `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
* </pre>
*
* <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
Expand All @@ -812,8 +790,6 @@ public com.google.bigtable.admin.v2.TableOrBuilder getTableOrBuilder() {
* <pre>
* Required. The table to update.
* The table's `name` field is used to identify the table to update.
* Format:
* `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
* </pre>
*
* <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
Expand Down
6 changes: 0 additions & 6 deletions ...able-admin-v2/src/main/java/com/google/bigtable/admin/v2/UpdateTableRequestOrBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ public interface UpdateTableRequestOrBuilder
* <pre>
* Required. The table to update.
* The table's `name` field is used to identify the table to update.
* Format:
* `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
* </pre>
*
* <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
Expand All @@ -45,8 +43,6 @@ public interface UpdateTableRequestOrBuilder
* <pre>
* Required. The table to update.
* The table's `name` field is used to identify the table to update.
* Format:
* `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
* </pre>
*
* <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
Expand All @@ -61,8 +57,6 @@ public interface UpdateTableRequestOrBuilder
* <pre>
* Required. The table to update.
* The table's `name` field is used to identify the table to update.
* Format:
* `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
* </pre>
*
* <code>.google.bigtable.admin.v2.Table table = 1 [(.google.api.field_behavior) = REQUIRED];
Expand Down
6 changes: 2 additions & 4 deletions ...loud-bigtable-admin-v2/src/main/proto/google/bigtable/admin/v2/bigtable_table_admin.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,8 +381,8 @@ message RestoreTableRequest {
// Name of the backup from which to restore. Values are of the form
// `projects/<project>/instances/<instance>/clusters/<cluster>/backups/<backup>`.
string backup = 3 [(google.api.resource_reference) = {
type: "bigtableadmin.googleapis.com/Backup"
}];
type: "bigtableadmin.googleapis.com/Backup"
}];
}
}

Expand Down Expand Up @@ -597,8 +597,6 @@ message GetTableRequest {
message UpdateTableRequest {
// Required. The table to update.
// The table's `name` field is used to identify the table to update.
// Format:
// `projects/{project}/instances/{instance}/tables/[_a-zA-Z0-9][-_.a-zA-Z0-9]*`
Table table = 1 [(google.api.field_behavior) = REQUIRED];

// Required. The list of fields to update.
Expand Down
12 changes: 11 additions & 1 deletion proto-google-cloud-bigtable-v2/clirr-ignored-differences.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,16 @@
<difference>
<differenceType>7012</differenceType>
<className>com/google/bigtable/v2/*OrBuilder</className>
<method>* has*(*)</method>
<method>* get*(*)</method>
</difference>
<difference>
<differenceType>7012</differenceType>
<className>com/google/bigtable/v2/*OrBuilder</className>
<method>boolean contains*(*)</method>
</difference>
<difference>
<differenceType>7012</differenceType>
<className>com/google/bigtable/v2/*OrBuilder</className>
<method>boolean has*(*)</method>
</difference>
</differences>
Loading