remove status from application latency

googleapis · May 11, 2022 · c5b312e · c5b312e
1 parent 24cd525
commit c5b312e
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 5 deletions.
diff --git a/...-bigtable-stats/src/main/java/com/google/cloud/bigtable/stats/BuiltinMetricsRecorder.java b/...-bigtable-stats/src/main/java/com/google/cloud/bigtable/stats/BuiltinMetricsRecorder.java
@@ -125,9 +125,22 @@ public void recordRetryCount(int attemptCount) {
     operationLevelNoStreaming.put(BuiltinMeasureConstants.RETRY_COUNT, attemptCount);
   }
 
-  public void recordApplicationLatency(long applicationLatency) {
-    operationLevelWithStreaming.put(
-        BuiltinMeasureConstants.APPLICATION_LATENCIES, applicationLatency);
+  public void recordApplicationLatency(
+      long applicationLatency, String tableId, String zone, String cluster) {
+    MeasureMap measures =
+        statsRecorder
+            .newMeasureMap()
+            .put(BuiltinMeasureConstants.APPLICATION_LATENCIES, applicationLatency);
+
+    TagContextBuilder tagCtx = newTagContextBuilder(tableId, zone, cluster);
+    if (operationType == OperationType.ServerStreaming
+        && spanName.getMethodName().equals("ReadRows")) {
+      tagCtx.putLocal(BuiltinMeasureConstants.STREAMING, TagValue.create("true"));
+    } else {
+      tagCtx.putLocal(BuiltinMeasureConstants.STREAMING, TagValue.create("false"));
+    }
+
+    measures.record(tagCtx.build());
   }
 
   public void recordFirstResponseLatency(long firstResponseLatency) {

diff --git a/...table-stats/src/test/java/com/google/cloud/bigtable/stats/BuiltinMetricsRecorderTest.java b/...table-stats/src/test/java/com/google/cloud/bigtable/stats/BuiltinMetricsRecorderTest.java
@@ -67,7 +67,7 @@ public void testStreamingOperation() throws InterruptedException {
     tracer.recordOperationLatencies(operationLatency);
     tracer.recordRetryCount(attemptCount);
     tracer.recordAttemptLatency(attemptLatency);
-    tracer.recordApplicationLatency(applicationLatency);
+    tracer.recordApplicationLatency(applicationLatency, TABLE_ID, ZONE, CLUSTER);
     tracer.recordGfeLatencies(serverLatency);
     tracer.recordGfeMissingHeaders(connectivityErrorCount);
     tracer.recordFirstResponseLatency(firstResponseLatency);
@@ -261,7 +261,7 @@ public void testUnaryOperations() throws InterruptedException {
     tracer.recordOperationLatencies(operationLatency);
     tracer.recordRetryCount(attemptCount);
     tracer.recordAttemptLatency(attemptLatency);
-    tracer.recordApplicationLatency(applicationLatency);
+    tracer.recordApplicationLatency(applicationLatency, TABLE_ID, ZONE, CLUSTER);
     tracer.recordGfeLatencies(serverLatency);
     tracer.recordGfeMissingHeaders(connectivityErrorCount);
     tracer.recordFirstResponseLatency(firstResponseLatency);