remove unary application latency streaming tag

googleapis · May 24, 2022 · 8a2aa0e · 8a2aa0e
1 parent d61ccfd
commit 8a2aa0e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 18 deletions.
diff --git a/...le/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsTracer.java b/...le/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsTracer.java
@@ -221,13 +221,13 @@ private void recordOperationCompletion(@Nullable Throwable status) {
       applicationLatencyTimer.stop();
       totalApplicationLatency.addAndGet(applicationLatencyTimer.elapsed(TimeUnit.MILLISECONDS));
     }
-    recorder.recordApplicationLatency(totalApplicationLatency.get(), tableId, zone, cluster);
 
     recorder.recordOperationLatencies(operationTimer.elapsed(TimeUnit.MILLISECONDS));
 
     if (operationType == ApiTracerFactory.OperationType.ServerStreaming
         && spanName.getMethodName().equals("ReadRows")) {
       recorder.recordFirstResponseLatency(firstResponsePerOpTimer.elapsed(TimeUnit.MILLISECONDS));
+      recorder.recordApplicationLatency(totalApplicationLatency.get(), tableId, zone, cluster);
     }
 
     recorder.recordOperationLevelWithoutStreaming(

diff --git a/...rc/test/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsTracerTest.java b/...rc/test/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsTracerTest.java
@@ -308,23 +308,6 @@ public void onComplete() {
     assertThat(longValue.getValue()).isLessThan(applicationLatency * (counter.get() + 1));
   }
 
-  @Test
-  public void testMutateRowApplicationLatency() {
-    // Unary callable application latency is the delay between retries
-    stub.mutateRowCallable()
-        .call(RowMutation.create(TABLE_ID, "random-row").setCell("cf", "q", "value"));
-
-    verify(builtinMetricsRecorder)
-        .recordApplicationLatency(
-            longValue.capture(), tableId.capture(), zone.capture(), cluster.capture());
-
-    // Application latency should be slightly less than the total delay between 2 requests observed
-    // from the server side. To make
-    // the test less flaky comparing with half of the server side delay here.
-    assertThat(longValue.getValue()).isAtLeast(serverTotalRetryDelay.get() / 2);
-    assertThat(longValue.getValue()).isAtMost(serverTotalRetryDelay.get());
-  }
-
   @Test
   public void testRetryCount() {
     stub.mutateRowCallable()