Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new configuration for nightly retry-related tests. #2319

Merged
merged 7 commits into from
Nov 14, 2023
Merged

feat: add new configuration for nightly retry-related tests. #2319

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7009c6d
feat: add new configuration for nightly retry-related tests.
Nov 14, 2023
c01b3d9
Add newlines to EOF
Nov 14, 2023
2bda766
Add more kokoro config, fix test commands
Nov 14, 2023
7f3e973
fix typo
Nov 14, 2023
5908ce5
Add new retry cfgs to owlbot exclude list
Nov 14, 2023
036b292
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Nov 14, 2023
383cbe1
Merge branch 'retry_e2e_kokoro' of https://github.com/egreco12/java-b…
gcf-owl-bot[bot] Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .kokoro/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,28 @@ clirr)
mvn -B -Denforcer.skip=true clirr:check
RETURN_CODE=$?
;;
retry_quota)
mvn -B ${INTEGRATION_TEST_ARGS} \
-Penable-integration-tests \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabling this profile will run all the other IT tests also. Do we need that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not; I changed the command to test with explicit -Dtest args, let me know if that still needs work

-DtrimStackTrace=false \
-Dclirr.skip=true \
-Denforcer.skip=true \
-Dit.test=ITBigQueryWriteQuotaRetryTest \
-fae \
verify
RETURN_CODE=$?
;;
retry_non_quota)
mvn -B ${INTEGRATION_TEST_ARGS} \
-Penable-integration-tests \
-DtrimStackTrace=false \
-Dclirr.skip=true \
-Denforcer.skip=true \
-Dit.test=ITBigQueryWriteNonQuotaRetryTest \
-fae \
verify
RETURN_CODE=$?
;;
*)
;;
esac
Expand Down
11 changes: 11 additions & 0 deletions .kokoro/nightly/retry_non_quota.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Format: //devtools/kokoro/config/proto/build.proto
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add some other env vars that the kokoro set up require.
This file is a good reference.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe, java-it-service-account is the name for the secret manager where the key is stored.


env_vars: {
key: "GOOGLE_CLOUD_PROJECT"
value: "bq-write-api-java-retry-test"
}

env_vars: {
key: "JOB_TYPE"
value: "retry_non_quota"
}
11 changes: 11 additions & 0 deletions .kokoro/nightly/retry_quota.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Format: //devtools/kokoro/config/proto/build.proto

env_vars: {
key: "GOOGLE_CLOUD_PROJECT"
value: "bq-writeapi-java-quota-retry"
}

env_vars: {
key: "JOB_TYPE"
value: "retry_quota"
}
Loading