Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add temp code replacement hack due to gapic code-gen template bug #201

Merged
merged 3 commits into from
Apr 22, 2020
Merged

chore: add temp code replacement hack due to gapic code-gen template bug #201

merged 3 commits into from
Apr 22, 2020

Conversation

stephaniewang526
Copy link
Contributor

@stephaniewang526 stephaniewang526 commented Apr 21, 2020 •
edited
Loading

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 21, 2020
@codecov
Copy link

codecov bot commented Apr 21, 2020 •
edited
Loading

Codecov Report

Merging #201 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #201   +/-   ##
=========================================
  Coverage     74.58%   74.58%           
  Complexity      344      344           
=========================================
  Files            45       45           
  Lines          2361     2361           
  Branches         82       82           
=========================================
  Hits           1761     1761           
  Misses          562      562           
  Partials         38       38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 440d85b...faa0287. Read the comment docs.

chingor13
chingor13 requested changes Apr 21, 2020
View reviewed changes
synth.py Outdated Show resolved Hide resolved
@stephaniewang526 stephaniewang526 changed the title fix: add file exclusion due to gapic code-gen template bug fix: add temp code replacement hack due to gapic code-gen template bug Apr 21, 2020
chingor13
chingor13 requested changes Apr 21, 2020
View reviewed changes
synth.py Outdated Show resolved Hide resolved
synth.py Outdated Show resolved Hide resolved
chingor13
chingor13 approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be a chore unless you want it to appear in the release notes

@stephaniewang526 stephaniewang526 changed the title fix: add temp code replacement hack due to gapic code-gen template bug chore: add temp code replacement hack due to gapic code-gen template bug Apr 21, 2020
@stephaniewang526 stephaniewang526 merged commit fbdb52a into googleapis:master Apr 22, 2020
This was referenced Apr 22, 2020
Closed
Closed
Closed
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
@renovate-bot
chore(deps): update dependency com.google.cloud:libraries-bom to v10 (g…
19e30d2 
…oogleapis#201)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephaniewang526 @chingor13 @googlebot