Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable maxTimeTravelHours in BigQuery java client library #3555

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

whuffman36
Copy link
Contributor

@whuffman36 whuffman36 commented Oct 28, 2024

The BigQuery API contains a field called maxTimeTravelHours that refers to the Time Travel Window feature. This feature allows users to query deleted or updated data for an amount of time specified in the maxTimeTravelHours parameter. This change exposes the maxTimeTravelHours to users of the client library so they can set and update the amount of time that deleted or updated data is stored for a given dataset.

Design Doc One Pager

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #3538 ☕️

The BigQuery API contains a field called maxTimeTravelHours that
refers to the Time Travel Window feature. This feature allows
users to query deleted or updated data for an amount of time
specified in the maxTimeTravelHours parameter. This change exposes
the maxTimeTravelHours to users of the client library so they can
set and update the amount of time that deleted or updated data
is stored for a given dataset.
@whuffman36 whuffman36 requested a review from a team as a code owner October 28, 2024 22:09
@whuffman36 whuffman36 requested a review from Neenu1995 October 28, 2024 22:09
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/java-bigquery API. labels Oct 28, 2024
@whuffman36 whuffman36 requested review from PhongChuong and removed request for Neenu1995 October 28, 2024 22:12
Copy link
Contributor

@PhongChuong PhongChuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a minor comment regarding a method description.

@whuffman36 whuffman36 changed the title Enable maxTimeTravelHours in BigQuery java client library feat: Enable maxTimeTravelHours in BigQuery java client library Oct 29, 2024
@whuffman36 whuffman36 requested a review from a team as a code owner October 29, 2024 21:46
@whuffman36 whuffman36 merged commit bd24fd8 into main Oct 30, 2024
17 checks passed
@whuffman36 whuffman36 deleted the travel-window branch October 30, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we get the configured time travel window for a Table
2 participants