Introduce language v1 proto and yaml file #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @bjwatson @anthmgoogle |
jmuk
changed the title
|
@jmuk LGTM, once it's time to merge this. |
|
FYI @swcloud, @jskeet, @jba, and @michaelbausor. These are the protos and config files you will need to generate gRPC and GAPIC code for NL v1. |
|
@jba Thank you for pinging me. I'll update genproto and cloud.google.com/go and keep you posted. |
3 tasks
|
@jmuk You have my LGTM from last week. |
|
The new proto file has been merged through the automated tool. Now this PR is only for yaml files. |
|
Note to language owners: if you already generated the GAPIC files last week with this PR, you don't have to regenerate them. The proto pushed to master is slightly different on some comments, but it won't affect GAPIC. |
|
Thanks @jmuk! |
|
@jmuk Good to know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.