Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.3.2 #53

Merged
merged 7 commits into from
Dec 20, 2018
Merged

Conversation

crwilcox
Copy link
Collaborator

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 18, 2018
@crwilcox
Copy link
Collaborator Author

The two tests that are failing fail on older builds also.

====================================================== FAILURES ======================================================
_______________________________________________ test_non_existent_file _______________________________________________
Traceback (most recent call last):
  File "/Users/crwilcox/workspace/google-resumable-media-python/tests/system/requests/test_download.py", line 292, in test_non_existent_file
    check_error_response(exc_info, http_client.NOT_FOUND, b'Not Found')
  File "/Users/crwilcox/workspace/google-resumable-media-python/tests/system/requests/test_download.py", line 257, in check_error_response
    assert response.content == message
AssertionError: assert b'No such obj...not-exist.txt' == b'Not Found'
  At index 2 diff: 32 != 116
  Left contains more items, first extra item: 98
  Use -v to get the full diff
_______________________________________________ test_chunked_download ________________________________________________
Traceback (most recent call last):
  File "/Users/crwilcox/workspace/google-resumable-media-python/tests/system/requests/test_download.py", line 407, in test_chunked_download
    total_bytes, actual_contents)
  File "/Users/crwilcox/workspace/google-resumable-media-python/tests/system/requests/test_download.py", line 379, in consume_chunks
    response = download.consume_next_chunk(authorized_transport)
  File "/Users/crwilcox/workspace/google-resumable-media-python/google/resumable_media/requests/download.py", line 225, in consume_next_chunk
    self._process_response(result)
  File "/Users/crwilcox/workspace/google-resumable-media-python/google/resumable_media/_download.py", line 348, in _process_response
    callback=self._make_invalid)
  File "/Users/crwilcox/workspace/google-resumable-media-python/google/resumable_media/_helpers.py", line 64, in header_required
    response, u'Response headers must contain header', name)
google.resumable_media.common.InvalidResponse: ('Response headers must contain header', 'content-length')
======================================== 2 failed, 20 passed in 30.96 seconds ========================================
nox > Command py.test tests/system failed with exit code 1
nox > Session system_tests(python_version='3.6') failed.

@crwilcox
Copy link
Collaborator Author

crwilcox commented Dec 20, 2018

For one of the tests an error changed from 'not found' to 'No such object: bucket-test-num/does-not-exist.txt'

The other issue seems to be missing a content-length. There is a content-range and the type is gzip. It works fine for the jpg files. Only the tar.gz file download is failing.

@crwilcox crwilcox force-pushed the release-google-resumable-media-python-0.3.2 branch from b811dae to 4d42f15 Compare December 20, 2018 22:19
@crwilcox crwilcox merged commit 68603db into master Dec 20, 2018
@tseaver tseaver deleted the release-google-resumable-media-python-0.3.2 branch May 29, 2019 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants