Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add googleapis-auth as codeowner team #923

Merged
merged 6 commits into from
Jul 25, 2022
Merged

feat: Add googleapis-auth as codeowner team #923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5b1344c
chore(deps): update dependency org.apache.maven.plugins:maven-project…
renovate-bot Jul 17, 2022
01a9840
fix: Fix format issues
lqiu96 Jul 18, 2022
f19859d
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jul 18, 2022
fda31da
Merge branch 'main' of https://github.com/googleapis/google-oauth-jav…
lqiu96 Jul 22, 2022
f859881
feat: Add googleapis-auth as codeowner team
lqiu96 Jul 22, 2022
a6c3cc5
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
# For syntax help see:
# https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax

* @googleapis/yoshi-java
# The @googleapis/googleapis-auth is the default owner for changes in this repo
* @googleapis/yoshi-java @googleapis/googleapis-auth
**/*.java @googleapis/googleapis-auth

# The java-samples-reviewers team is the default owner for samples changes
samples/**/*.java @googleapis/java-samples-reviewers
2 changes: 2 additions & 0 deletions .github/sync-repo-settings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,5 @@ permissionRules:
permission: admin
- team: yoshi-java
permission: push
- team: googleapis-auth
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change might be overridden to this file by the nightly owlbot template sync job, so we may need to add this file to the ignore list in owlbot.py. Is that correct @suztomo ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added Write role to googleapis-auth team via 'Settings'. Edit to .github/sync-repo-settings.yaml is not needed.

I observed OwlBot does not override the file googleapis/synthtool#1494 (comment)

permission: push
3 changes: 2 additions & 1 deletion .repo-metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@
"repo": "googleapis/google-oauth-java-client",
"repo_short": "google-oauth-java-client",
"library_type": "AUTH",
"distribution_name": "com.google.oauth-client:google-oauth-client"
"distribution_name": "com.google.oauth-client:google-oauth-client",
"codeowner_team": "@googleapis/googleapis-auth"
}