chore: add native-image-shared-config as parent #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: This pull request is touching the following templated files:
|
| @@ -3,7 +3,7 @@ | |||
| # Configure the docker image for kokoro-trampoline. | |||
| env_vars: { | |||
| key: "TRAMPOLINE_IMAGE" | |||
| value: "gcr.io/cloud-devrel-kokoro-resources/graalvm:22.3.3" | |||
| value: "gcr.io/cloud-devrel-public-resources/graalvm_a:1.7.1" | |||
There was a problem hiding this comment.
Should these graalvm-native-x.cfgs have a dependabot/renovatebot comment to tie the version to native-image-shared-config?
There was a problem hiding this comment.
Good point, enabled renovate-bot to update the java-shared-config version. Tested at mpeddada1/forking-renovate-repro#8
renovate.json
Outdated
| "^.kokoro/presubmit/graalvm-native.*.cfg$" | ||
| ], | ||
| "matchStrings": ["value: \"gcr.io/cloud-devrel-public-resources/graalvm.*:(?<currentValue>.*?)\""], | ||
| "depNameTemplate": "com.google.cloud:google-cloud-shared-config", |
There was a problem hiding this comment.
Does this repo know about google-cloud-shared-config? Or should this be native-image-shared-config?
There was a problem hiding this comment.
Good catch. For consistency, it makes sense for this to use native-image-shared-config.
…ogle-http-java-client into parent-native-image-config
burkedavison
approved these changes
Dec 11, 2023
mpeddada1
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.