-
Notifications
You must be signed in to change notification settings - Fork 452
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: NPE if response entity is null (#2043)
* fix npe * fix npe * fix npe * fix npe
- Loading branch information
Showing
4 changed files
with
88 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
...apache-v5/src/test/java/com/google/api/client/http/apache/v5/Apache5HttpResponseTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
/* | ||
* Copyright 2024 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except | ||
* in compliance with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software distributed under the License | ||
* is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express | ||
* or implied. See the License for the specific language governing permissions and limitations under | ||
* the License. | ||
*/ | ||
|
||
package com.google.api.client.http.apache.v5; | ||
|
||
import static org.junit.Assert.assertNotNull; | ||
|
||
import java.io.InputStream; | ||
import org.apache.hc.client5.http.classic.methods.HttpPost; | ||
import org.apache.hc.client5.http.classic.methods.HttpUriRequestBase; | ||
import org.junit.Test; | ||
|
||
public class Apache5HttpResponseTest { | ||
@Test | ||
public void testNullContent() throws Exception { | ||
HttpUriRequestBase base = new HttpPost("http://www.google.com"); | ||
MockClassicHttpResponse mockResponse = new MockClassicHttpResponse(); | ||
mockResponse.setEntity(null); | ||
Apache5HttpResponse response = new Apache5HttpResponse(base, mockResponse); | ||
|
||
InputStream content = response.getContent(); | ||
|
||
assertNotNull(content); | ||
} | ||
} |
44 changes: 44 additions & 0 deletions
44
...che-v5/src/test/java/com/google/api/client/http/apache/v5/Apache5ResponseContentTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
/* | ||
* Copyright 2024 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except | ||
* in compliance with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software distributed under the License | ||
* is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express | ||
* or implied. See the License for the specific language governing permissions and limitations under | ||
* the License. | ||
*/ | ||
|
||
package com.google.api.client.http.apache.v5; | ||
|
||
import java.io.IOException; | ||
import java.io.InputStream; | ||
import org.junit.Test; | ||
|
||
public class Apache5ResponseContentTest { | ||
@Test | ||
public void testNullResponseContent_doesNotThrowExceptionOnClose() throws Exception { | ||
Apache5ResponseContent response = | ||
new Apache5ResponseContent( | ||
new InputStream() { | ||
@Override | ||
public int read() throws IOException { | ||
return 0; | ||
} | ||
}, | ||
null); | ||
|
||
response.close(); | ||
} | ||
|
||
@Test | ||
public void testNullWrappedContent_doesNotThrowExceptionOnClose() throws Exception { | ||
MockClassicHttpResponse mockResponse = new MockClassicHttpResponse(); | ||
Apache5ResponseContent response = new Apache5ResponseContent(null, mockResponse); | ||
|
||
response.close(); | ||
} | ||
} |