Skip to content

Commit

Permalink
fix: NPE if response entity is null (#2043)
Browse files Browse the repository at this point in the history
* fix npe

* fix npe

* fix npe

* fix npe
  • Loading branch information
ldetmer authored Dec 4, 2024
1 parent 3453864 commit 12c742b
Show file tree
Hide file tree
Showing 4 changed files with 88 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ public int getStatusCode() {

@Override
public InputStream getContent() throws IOException {
return new Apache5ResponseContent(entity.getContent(), response);
InputStream content = entity == null ? null : entity.getContent();
return new Apache5ResponseContent(content, response);
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,12 @@ public synchronized void reset() throws IOException {

@Override
public void close() throws IOException {
wrappedStream.close();
response.close();
if (wrappedStream != null) {
wrappedStream.close();
}
if (response != null) {
response.close();
}
}

@Override
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
/*
* Copyright 2024 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
* in compliance with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software distributed under the License
* is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
* or implied. See the License for the specific language governing permissions and limitations under
* the License.
*/

package com.google.api.client.http.apache.v5;

import static org.junit.Assert.assertNotNull;

import java.io.InputStream;
import org.apache.hc.client5.http.classic.methods.HttpPost;
import org.apache.hc.client5.http.classic.methods.HttpUriRequestBase;
import org.junit.Test;

public class Apache5HttpResponseTest {
@Test
public void testNullContent() throws Exception {
HttpUriRequestBase base = new HttpPost("http://www.google.com");
MockClassicHttpResponse mockResponse = new MockClassicHttpResponse();
mockResponse.setEntity(null);
Apache5HttpResponse response = new Apache5HttpResponse(base, mockResponse);

InputStream content = response.getContent();

assertNotNull(content);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
/*
* Copyright 2024 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
* in compliance with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software distributed under the License
* is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
* or implied. See the License for the specific language governing permissions and limitations under
* the License.
*/

package com.google.api.client.http.apache.v5;

import java.io.IOException;
import java.io.InputStream;
import org.junit.Test;

public class Apache5ResponseContentTest {
@Test
public void testNullResponseContent_doesNotThrowExceptionOnClose() throws Exception {
Apache5ResponseContent response =
new Apache5ResponseContent(
new InputStream() {
@Override
public int read() throws IOException {
return 0;
}
},
null);

response.close();
}

@Test
public void testNullWrappedContent_doesNotThrowExceptionOnClose() throws Exception {
MockClassicHttpResponse mockResponse = new MockClassicHttpResponse();
Apache5ResponseContent response = new Apache5ResponseContent(null, mockResponse);

response.close();
}
}

0 comments on commit 12c742b

Please sign in to comment.