Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples(storage): create bucket with HNS configuration enabled #26020

Merged
merged 4 commits into from
Jun 7, 2024
Merged

samples(storage): create bucket with HNS configuration enabled #26020

merged 4 commits into from
Jun 7, 2024

Conversation

bajajneha27
Copy link
Contributor

closes: #25992

@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented May 31, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. labels May 31, 2024
@bajajneha27 bajajneha27 requested review from aandreassa, dazuma, sydney-munro and cojenco and removed request for sydney-munro May 31, 2024 13:07
This was referenced May 31, 2024
Closed
Closed
Closed
Closed
Closed
Closed
dazuma
dazuma requested changes Jun 4, 2024
View reviewed changes
google-cloud-storage/samples/acceptance/buckets_test.rb Outdated
@@ -144,6 +145,26 @@
end
end

describe "storage_create_bucket_hierarchical_namespace" do
focus
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the focus

@bajajneha27 bajajneha27 requested a review from dazuma June 7, 2024 03:42
dazuma
dazuma approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the failing tests are unrelated.

@bajajneha27 bajajneha27 merged commit f0fc4b3 into googleapis:main Jun 7, 2024
13 of 14 checks passed
@yoshi-approver yoshi-approver added the release-please:force-run To run release-please label Jun 7, 2024
@release-please release-please bot removed the release-please:force-run To run release-please label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dazuma dazuma dazuma approved these changes

@aandreassa aandreassa Awaiting requested review from aandreassa

@cojenco cojenco Awaiting requested review from cojenco

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storage: add HNS folders samples
3 participants
@bajajneha27 @dazuma @yoshi-approver