Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(automl): fix TypeError when passing a client_info to automl TablesClient #9949

Merged
merged 3 commits into from
Dec 17, 2019
Merged

fix(automl): fix TypeError when passing a client_info to automl TablesClient #9949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
330bcde
fix(automl): fix TypeError when passing a client_info to automl Table…
vimota Dec 9, 2019
6eb6fc7
fix(automl): delete client_info from kwargs instead and pass named pa…
vimota Dec 12, 2019
402857f
fix format
vimota Dec 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions automl/google/cloud/automl_v1beta1/tables/tables_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ def __init__(
else:
client_info_.user_agent = user_agent
client_info_.gapic_version = version
Copy link
Contributor

@helinwang helinwang Dec 12, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
I think it's good to encourage being explicit with the argument. E.g., prefer explicit argument than using kwargs.
Instead of removing the client_info argument, could you change the solution to removing "client_info" from kwargs after this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks!

kwargs.pop("client_info", None)

if client is None:
self.auto_ml_client = gapic.auto_ml_client.AutoMlClient(
Expand Down
11 changes: 11 additions & 0 deletions automl/tests/unit/gapic/v1beta1/test_tables_client_v1beta1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1424,3 +1424,14 @@ def test_prediction_client_credentials(self):
_, prediction_client_kwargs = MockPredictionClient.call_args
assert "credentials" in prediction_client_kwargs
assert prediction_client_kwargs["credentials"] == credentials_mock

def test_prediction_client_client_info(self):
client_info_mock = mock.Mock()
patch_prediction_client = mock.patch(
"google.cloud.automl_v1beta1.gapic.prediction_service_client.PredictionServiceClient"
)
with patch_prediction_client as MockPredictionClient:
client = automl_v1beta1.TablesClient(client_info=client_info_mock)
_, prediction_client_kwargs = MockPredictionClient.call_args
assert "client_info" in prediction_client_kwargs
assert prediction_client_kwargs["client_info"] == client_info_mock