Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(bigquery): fix undelete table system test to use milliseconds in snapshot decorator #9649

Merged
merged 1 commit into from
Nov 9, 2019
Merged

chore(bigquery): fix undelete table system test to use milliseconds in snapshot decorator #9649

merged 1 commit into from
Nov 9, 2019

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Nov 8, 2019

This fixes a flakey system test, where sometimes we sent an invalid
timestamp as a snapshot to copy from.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #9633

@tswast
chore(bigquery): fix undelete table system test to use milliseconds i…
5bb8f4a 
…n snapshot decorator

This fixes a flakey system test, where sometimes we sent an invalid
timestamp as a snapshot to copy from.
@tswast tswast requested a review from a team November 8, 2019 23:39
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2019
@tswast tswast requested a review from busunkim96 November 8, 2019 23:48
@tswast tswast merged commit 7f7d1b5 into googleapis:master Nov 9, 2019
@tswast tswast deleted the issue9633-undelete branch November 9, 2019 00:48
@busunkim96 busunkim96 mentioned this pull request Nov 11, 2019
Merged
@yoshi-automation yoshi-automation mentioned this pull request Jan 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery: 'test_undelete_table' fails with 500
3 participants
@tswast @busunkim96 @googlebot