Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(billingbudgets): initial generation of billing budget #9622

Merged
merged 4 commits into from
Nov 14, 2019

Conversation

busunkim96
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 6, 2019
@busunkim96 busunkim96 changed the title feat(billingbudgets): initial generation of billing budget v1beta1 feat(billingbudgets): initial generation of billing budget Nov 6, 2019
@busunkim96 busunkim96 requested a review from a team November 7, 2019 00:11
@@ -0,0 +1,75 @@
Python Client for Cloud Billing Budget API (`Alpha`_)
=====================================================
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a top-level summary description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

billingbudgets.yaml is missing a summary line. I've asked the API team to add one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to wait on that change and update the PR with the same text?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I'll keep this open until I see the change to the protos

billingbudgets/docs/README.rst Outdated Show resolved Hide resolved
billingbudgets/.repo-metadata.json Outdated Show resolved Hide resolved
billingbudgets/README.rst Outdated Show resolved Hide resolved
billingbudgets/README.rst Outdated Show resolved Hide resolved
billingbudgets/README.rst Outdated Show resolved Hide resolved
billingbudgets/setup.py Outdated Show resolved Hide resolved
@busunkim96 busunkim96 force-pushed the billing-budget-v1beta1 branch from 8faa130 to c054f77 Compare November 7, 2019 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants