Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner): add instance replica info; annotate protos, update docstrings (via synth) #9577

Merged
merged 1 commit into from
Nov 12, 2019
Merged

feat(spanner): add instance replica info; annotate protos, update docstrings (via synth) #9577

merged 1 commit into from
Nov 12, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 31, 2019

Closes #9575.

@tseaver tseaver added api: spanner Issues related to the Spanner API. codegen labels Oct 31, 2019
@tseaver tseaver requested a review from frankyn as a code owner October 31, 2019 15:12
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 31, 2019
@tseaver
Copy link
Contributor Author

tseaver commented Oct 31, 2019

Systest flakes due to #9534 (fix pending in #9579).

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 5, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 5, 2019
@tseaver
Copy link
Contributor Author

tseaver commented Nov 5, 2019

@frankyn, @crwilcox, @busunkim96 PTAL

@tseaver
Copy link
Contributor Author

tseaver commented Nov 11, 2019

@crwilcox, @busunkim96 PTAL

busunkim96
busunkim96 approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the caveat that I'm not familiar with the spanner code.

Daniel Azuma put out a warning in the Yoshi chatroom after reviewing the Ruby PR, but it doesn't seem to be an issue here?

We noticed that the latest spanner update introduced a breaking change at least in Ruby and PHP (some fields changed from required to optional, and as a result moved from positional to keyword arguments). Python and Node, you might want to check if that happened to you also.

@tseaver
Copy link
Contributor Author

tseaver commented Nov 11, 2019

@busunkim96 I don't see anything in our generated clients (instance admin, database admin, data) which includes such breaking changes.

@dazuma Were there specific APIs whose wrappers introduced such changes for Ruby / PHP?

@tseaver tseaver merged commit d17f295 into googleapis:master Nov 12, 2019
@tseaver tseaver deleted the 9575-spanner-manual-synth branch November 12, 2019 01:53
@yoshi-automation yoshi-automation mentioned this pull request Jan 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

@frankyn frankyn Awaiting requested review from frankyn

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. codegen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @busunkim96 @googlebot @yoshi-kokoro