docs(bigquery): document how to achieve higher write limit and add tests #9574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plamut
added
api: bigquery
googlebot
added
the
cla: yes
tseaver
suggested changes
Oct 31, 2019
|
Renamed the methods along with the files as well for consistency. |
tswast
approved these changes
Nov 1, 2019
tseaver
approved these changes
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9539.
This PR documents how to achieve the higher write limit on streaming inserts, and extends unit tests to cover that case (i.e. no row insert IDs).
How to test
As mentioned in the last issue comment - check that the new code sample and the docs are indeed valid, and that new tests are sound