Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(spanner): update description of the timeout_secs parameter #9381

Merged
merged 3 commits into from
Oct 29, 2019
Merged

docs(spanner): update description of the timeout_secs parameter #9381

merged 3 commits into from
Oct 29, 2019

Conversation

emar-kar
Copy link
Contributor

@emar-kar emar-kar commented Oct 1, 2019

Closes: #9364

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 1, 2019
@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2019
@emar-kar emar-kar marked this pull request as ready for review October 1, 2019 16:24
larkee
larkee reviewed Oct 22, 2019
View reviewed changes
spanner/google/cloud/spanner_v1/database.py Outdated
If passed, "timeout_secs" will be removed and used to
override the default timeout.
override the default timeout which defines maximum timestamp
Copy link
Contributor

@larkee larkee Oct 22, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps reword it to override the retry timeout as default timeout is still vague even with the explanation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got your point and I think it better be called the default retry timeout.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

spanner/google/cloud/spanner_v1/session.py Outdated
If passed, "timeout_secs" will be removed and used to
override the default timeout.
override the default timeout which defines maximum timestamp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

larkee
larkee approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tseaver tseaver merged commit ee62142 into googleapis:master Oct 29, 2019
@emar-kar emar-kar deleted the iss-9364 branch November 5, 2019 08:30
@yoshi-automation yoshi-automation mentioned this pull request Jan 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkee larkee larkee approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

@frankyn frankyn Awaiting requested review from frankyn

@tseaver tseaver Awaiting requested review from tseaver

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spanner: Update docs for timeout_secs param in Database.run_in_transaction()
6 participants
@emar-kar @larkee @tseaver @googlebot @IlyaFaer @yoshi-kokoro