Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(dlp): fix potentially unsent env variable and enable skipped tests #9300

Closed
wants to merge 15 commits into from
Closed

test(dlp): fix potentially unsent env variable and enable skipped tests #9300

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
035f9c7
test(dlp): fix potentially unsent env variable and enable skipped tests.
maximus12793 Sep 24, 2019
5ace257
Remove list skips
maximus12793 Sep 24, 2019
e5f124a
test(dlp): fix potentially unsent env variable and enable skipped tests.
maximus12793 Sep 25, 2019
9ee1dd4
test(dlp): fix potentially unsent env variable and enable skipped tests.
maximus12793 Sep 25, 2019
6d4c4ff
Merge branch 'master' of github.com:maximus12793/google-cloud-python
maximus12793 Sep 25, 2019
f8b1cc1
fix typo deidentify content
maximus12793 Oct 11, 2019
854491d
Update test_system_dlp_service_v2_vpcsc.py
maximus12793 Oct 11, 2019
41f8d1f
Merge branch 'master' of github.com:googleapis/google-cloud-python
maximus12793 Oct 11, 2019
624d2fd
Merge branch 'master' of github.com:maximus12793/google-cloud-python
maximus12793 Oct 11, 2019
6e10503
fix typo
maximus12793 Oct 15, 2019
89e2ce9
fix typo
maximus12793 Oct 15, 2019
6a9b24e
Merge branch 'master' of github.com:maximus12793/google-cloud-python
maximus12793 Oct 22, 2019
c4f167f
Merge commit 'af96c3e66993eb0a52aca3a2f910c9cf7c61131b'
maximus12793 Oct 22, 2019
6148595
Merge branch 'master' of github.com:googleapis/google-cloud-python
maximus12793 Oct 22, 2019
0524e35
temp
maximus12793 Oct 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions dlp/tests/system/gapic/v2/test_system_dlp_service_v2_vpcsc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,6 @@ def test_get_inspect_template(self):
delayed_outside = lambda: client.get_inspect_template(name_outside)
TestSystemDlpService._do_test(delayed_inside, delayed_outside)

@pytest.mark.skip(reason="List tests are currently not supported")
@pytest.mark.skipif(
not IS_INSIDE_VPCSC,
reason="This test requires a VPCSC and setting GOOGLE_CLOUD_TESTS_IN_VPCSC",
Expand Down Expand Up @@ -244,7 +243,6 @@ def test_get_deidentify_template(self):
delayed_outside = lambda: client.get_deidentify_template(name_outside)
TestSystemDlpService._do_test(delayed_inside, delayed_outside)

@pytest.mark.skip(reason="List tests are currently not supported")
@pytest.mark.skipif(
not IS_INSIDE_VPCSC,
reason="This test requires a VPCSC and setting GOOGLE_CLOUD_TESTS_IN_VPCSC",
Expand Down Expand Up @@ -293,7 +291,6 @@ def test_create_dlp_job(self):
delayed_outside = lambda: client.create_dlp_job(name_outside)
TestSystemDlpService._do_test(delayed_inside, delayed_outside)

@pytest.mark.skip(reason="List tests are currently not supported")
@pytest.mark.skipif(
not IS_INSIDE_VPCSC,
reason="This test requires a VPCSC and setting GOOGLE_CLOUD_TESTS_IN_VPCSC",
Expand Down Expand Up @@ -358,7 +355,6 @@ def test_cancel_dlp_job(self):
delayed_outside = lambda: client.cancel_dlp_job(name_outside)
TestSystemDlpService._do_test(delayed_inside, delayed_outside)

@pytest.mark.skip(reason="List tests are currently not supported")
@pytest.mark.skipif(
not IS_INSIDE_VPCSC,
reason="This test requires a VPCSC and setting GOOGLE_CLOUD_TESTS_IN_VPCSC",
Expand Down Expand Up @@ -487,7 +483,6 @@ def test_get_stored_info_type(self):
delayed_outside = lambda: client.get_stored_info_type(name_outside)
TestSystemDlpService._do_test(delayed_inside, delayed_outside)

@pytest.mark.skip(reason="List tests are currently not supported")
@pytest.mark.skipif(
not IS_INSIDE_VPCSC,
reason="This test requires a VPCSC and setting GOOGLE_CLOUD_TESTS_IN_VPCSC",
Expand Down