Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage: Move benchwrapper directory into 'tests/perf/'. #9246

Merged
merged 4 commits into from
Sep 18, 2019
Merged

Storage: Move benchwrapper directory into 'tests/perf/'. #9246

merged 4 commits into from
Sep 18, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 18, 2019

@jadekler Moving to keep the root directory with just 'tests'.

@tseaver tseaver added api: storage Issues related to the Cloud Storage API. testing labels Sep 18, 2019
@tseaver tseaver requested review from crwilcox and jeanbza September 18, 2019 17:19
@tseaver tseaver requested a review from frankyn as a code owner September 18, 2019 17:19
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 18, 2019
jeanbza
jeanbza reviewed Sep 18, 2019
View reviewed changes
Copy link
Contributor

@jeanbza jeanbza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine with me, but do we have quorum on this location? Each time we move it I have to update configs, so I'd love to pic one canonical spot and copy it everywhere. :)

@tseaver
Copy link
Contributor Author

tseaver commented Sep 18, 2019

@jadekler Moving those files puts them in a normal / expected location (e.g., so that lint / black run), and eases command-line completion (no conflict between tests and test_utils).

@tseaver tseaver merged commit f890d29 into googleapis:master Sep 18, 2019
@tseaver tseaver deleted the storage-move-benchwrapper branch September 18, 2019 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanbza jeanbza jeanbza approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

@frankyn frankyn Awaiting requested review from frankyn

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @jeanbza @googlebot