Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#903: Ensure transaction ID is passed through to connection during commit. #904

Merged
merged 1 commit into from
Jun 1, 2015
Merged

#903: Ensure transaction ID is passed through to connection during commit. #904

merged 1 commit into from
Jun 1, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 1, 2015

Fixes #903.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 1, 2015
@dhermes
Copy link
Contributor

dhermes commented Jun 1, 2015

LGTM. Seems leakier than need be (i.e. we could put the ID in the commit signature and Batch wouldn't need to know about the ID)

Pretty scary that was happening

@tseaver
Copy link
Contributor Author

tseaver commented Jun 1, 2015

Having transaction_id in the signature of Transaction.commit would be pretty silly.

My initial pass gave Batch.commit() an optional _transaction_id parameter, documented as "for use only by Transaction.commit(), but pylint put the kibosh on it (it doesn't want the subclass to have a different signature than the superclass.

tseaver added a commit that referenced this pull request Jun 1, 2015
#903: Ensure transaction ID is passed through to connection during commit.
@tseaver tseaver merged commit 9491053 into googleapis:master Jun 1, 2015
@tseaver tseaver deleted the 903-pass_xact_id_during_commit branch June 1, 2015 16:02
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 164e1d8 on tseaver:903-pass_xact_id_during_commit into * on GoogleCloudPlatform:master*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transactions are commited in CommitRequest.NON_TRANSACTIONAL mode
4 participants