Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Core / BigQuery Storage: Fix pins of 'googleapis-common-protos. #8688

Merged
merged 2 commits into from
Jul 17, 2019
Merged

API Core / BigQuery Storage: Fix pins of 'googleapis-common-protos. #8688

merged 2 commits into from
Jul 17, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 16, 2019

Toward #8686.

@tseaver tseaver added packaging api: core api: bigquerystorage Issues related to the BigQuery Storage API. labels Jul 16, 2019
@tseaver tseaver requested review from tswast, crwilcox, busunkim96 and a team July 16, 2019 18:33
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 16, 2019
@tseaver tseaver mentioned this pull request Jul 16, 2019
Closed
31 tasks
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 16, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 16, 2019
@tswast
Copy link
Contributor

tswast commented Jul 16, 2019

E ModuleNotFoundError: No module named '_bz2'

There's a good chance this was caused by a bad wheel for pyarrow. We might need to pin to pyarrow 0.13.0 for now.

@tseaver
Copy link
Contributor Author

tseaver commented Jul 17, 2019

@tswast bz2 is part of the standard library: I think there has been breakage in the docker images (no installing libbz2-dev before building Python from source).

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 17, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 17, 2019
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 17, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 17, 2019
@busunkim96
Copy link
Contributor

I moved 'latest' back to an older build from March and got the same error 🤷‍♀️ Rebuilding and republishing the image right now.

@busunkim96
Copy link
Contributor

Please hold off on merging. The latest test run skipped a bunch of sessions: https://g3c.corp.google.com/results/invocations;query=target/07a1a87e-228d-4d99-9281-2682932d1b3e/targets/cloud-devrel%2Fclient-libraries%2Fgoogle-cloud-python%2Fpresubmit%2Fbigquery_storage/log

@tseaver
Copy link
Contributor Author

tseaver commented Jul 17, 2019

@busunkim96 They look green to me now. The two which are not no-ops both succeeded:

@busunkim96 busunkim96 added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jul 17, 2019
@tseaver tseaver merged commit 29b3c4d into googleapis:master Jul 17, 2019
@tseaver tseaver deleted the 8686-api_core-bump-googleapis-common-protos-pin branch July 17, 2019 18:47
birnbaum added a commit to birnbaum/google-api-core-feedstock that referenced this pull request Jul 22, 2019
@birnbaum
googleapis-common-protos dependency changed
2943d0f 
The current build of 1.14.0 is not reflecting the new pins of 'googleapis-common-protos': googleapis/google-cloud-python#8688
@birnbaum birnbaum mentioned this pull request Jul 22, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffnay steffnay steffnay approved these changes

@tswast tswast Awaiting requested review from tswast

@crwilcox crwilcox Awaiting requested review from crwilcox

@busunkim96 busunkim96 Awaiting requested review from busunkim96

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the BigQuery Storage API. api: core cla: yes This human has signed the Contributor License Agreement. packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tseaver @tswast @busunkim96 @steffnay @googlebot @yoshi-kokoro