#827: Use short form imports in pubsub docs #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Does this have another PR as a diffbase? Overall LGTM. I noticed you added a forgotten method to |
| @@ -45,16 +45,16 @@ List topics for the default project: | |||
|
|
|||
| .. doctest:: | |||
|
|
|||
| >>> from gcloud import pubsub | |||
| >>> [topic.name for topic in pubsub.list_topics()] # API request | |||
| >>> from gcloud.pubsub import list_topics | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM |
#847 (the original description says so.
This isn't API reference documentation -- it is "common pattern" / usage docs. |
tseaver
added a commit
that referenced
this pull request
Apr 29, 2015
#827: Use short form imports in pubsub docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses #847 as a base.
Per #827.
@jgeewax, PTAL (particuarly at 4e1d2c9).