Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more expressive module docstring to batch.py #826

Merged
merged 1 commit into from
Apr 16, 2015
Merged

Added more expressive module docstring to batch.py #826

merged 1 commit into from
Apr 16, 2015

Conversation

jgeewax
Copy link
Contributor

@jgeewax jgeewax commented Apr 15, 2015

No description provided.

@jgeewax jgeewax added api: datastore Issues related to the Datastore API. docs labels Apr 15, 2015
@jgeewax jgeewax added this to the Datastore Future milestone Apr 15, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 15, 2015
@jgeewax
Copy link
Contributor Author

jgeewax commented Apr 15, 2015

Looks like lint is failing... but not saying why. Running pylint says the line is too long... Any ideas how I could make the line shorter without cutting the hyperlink? @tseaver

@tseaver
Copy link
Contributor

tseaver commented Apr 15, 2015

@jgeewax Pylint only allows hyperlinks > 80 characters if they are standalone on the line. E.g., https://github.com/GoogleCloudPlatform/gcloud-python/blob/6283ab9c9d7fa06f6800079bd882b573c4de7cf7/gcloud/pubsub/api.py#L28

@dhermes
Copy link
Contributor

dhermes commented Apr 15, 2015

Also the link has 84 chars, 8 of which are https://, so you could just use the link on its own line

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e765268 on jgeewax:master into * on GoogleCloudPlatform:master*.

@jgeewax
Copy link
Contributor Author

jgeewax commented Apr 16, 2015

Assigning to @tseaver for review

tseaver
tseaver reviewed Apr 16, 2015
View reviewed changes
gcloud/datastore/batch.py

See
https://cloud.google.com/datastore/docs/concepts/entities#Datastore_Batch_operations
for more information.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 283217a on jgeewax:master into * on GoogleCloudPlatform:master*.

@tseaver
Copy link
Contributor

tseaver commented Apr 16, 2015

LGTM

jgeewax added a commit that referenced this pull request Apr 16, 2015
@jgeewax
Merge pull request #826 from jgeewax/master
36dc616 
Added more expressive module docstring to batch.py
@jgeewax jgeewax merged commit 36dc616 into googleapis:master Apr 16, 2015
@dhermes dhermes mentioned this pull request Jun 4, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tseaver tseaver

Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
Datastore Future
Development

Successfully merging this pull request may close these issues.
5 participants
@jgeewax @tseaver @dhermes @coveralls @googlebot