Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: add 'v1' fork. #7494

Merged
merged 7 commits into from
Mar 28, 2019
Merged

Firestore: add 'v1' fork. #7494

merged 7 commits into from
Mar 28, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 6, 2019

No description provided.

@tseaver tseaver added the api: firestore Issues related to the Firestore API. label Mar 6, 2019
@tseaver tseaver requested a review from crwilcox March 6, 2019 20:43
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 6, 2019
@tseaver
Copy link
Contributor Author

tseaver commented Mar 6, 2019

The listen system tests are failing with the following error code:

 400 Missing required http header 'google-cloud-resource-prefix' or query param 'database'.

I have asked for clarification about docs for the new requirement.

@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 6, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Mar 13, 2019
@tseaver tseaver removed 🚨 This issue needs some love. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Mar 27, 2019
@tseaver
Copy link
Contributor Author

tseaver commented Mar 27, 2019 •
edited
Loading

@crwilcox I have rebased against current master, updated to match the rpc_metadata -> metadata change, and applied the same changes to the firestore_v1 tree. System tests pass locally, modulo the known-flaky test_watch_collection (#7130). PTAL.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Mar 27, 2019
@crwilcox crwilcox merged commit 8942439 into googleapis:master Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox crwilcox approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @crwilcox @googlebot @yoshi-automation