Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep firestore unit tests for generation from 'v1' protos. #7437

Merged
merged 2 commits into from
Mar 5, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions firestore/tests/unit/v1beta1/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Copyright 2017 Google LLC
tseaver marked this conversation as resolved.
Show resolved Hide resolved
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ class TestClient(unittest.TestCase):

@staticmethod
def _get_target_class():
from google.cloud import firestore
from google.cloud.firestore_v1beta1.client import Client

return firestore.Client
return Client

def _make_one(self, *args, **kwargs):
klass = self._get_target_class()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ def _load_testproto(filename):
return test_proto


ALL_TESTPROTOS = [
_load_testproto(filename)
for filename in sorted(glob.glob("tests/unit/testdata/*.textproto"))
]
_here = os.path.dirname(__file__)
_glob_expr = "{}/testdata/*.textproto".format(_here)
_globs = glob.glob(_glob_expr)
ALL_TESTPROTOS = [_load_testproto(filename) for filename in sorted(_globs)]

_CREATE_TESTPROTOS = [
test_proto
Expand Down