-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add templating to asset synth.py #6606
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Nov 20, 2018
It looks like flake and black are in disagreement over some things. |
We could reference Black's .flake8 configuration and update the template's .flake8 to match: https://github.com/ambv/black/blob/master/.flake8 |
I think the issue is I didn't commit .flake8. Adding now. |
busunkim96
approved these changes
Nov 20, 2018
tseaver
reviewed
Nov 22, 2018
|
||
# Install all test dependencies, then install this package into the | ||
# virtualenv's dist-packages. | ||
session.install("mock", "pytest") |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
erikwebb
pushed a commit
to erikwebb/google-cloud-python
that referenced
this pull request
Dec 3, 2018
* add templating to asset synth.py
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
* add templating to asset synth.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.